Conversation
moritzraho
force-pushed
the
feat/expose-oauth-s2s-env
branch
from
4f22b03 to
86b932c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Jan 22, 2026
moritzraho
commented
Jan 22, 2026
| if (typeof oauthS2SCredential === 'object') { | ||
| extraEnvVars = { [SERVICE_API_KEY_ENV]: serviceClientId, [IMS_OAUTH_S2S_ENV]: JSON.stringify(oauthS2SCredential) } | ||
| } else { | ||
| extraEnvVars = { [SERVICE_API_KEY_ENV]: serviceClientId } |
Member
Author
There was a problem hiding this comment.
Note: we should deprecate and delete that one eventually
Member
There was a problem hiding this comment.
which are you referring to? perhaps we need to file a jira so we don't forget
Member
Author
There was a problem hiding this comment.
the SERVICE_API_KEY=<client_id>
shazron
approved these changes
Jan 27, 2026
| if (typeof oauthS2SCredential === 'object') { | ||
| extraEnvVars = { [SERVICE_API_KEY_ENV]: serviceClientId, [IMS_OAUTH_S2S_ENV]: JSON.stringify(oauthS2SCredential) } | ||
| } else { | ||
| extraEnvVars = { [SERVICE_API_KEY_ENV]: serviceClientId } |
Member
There was a problem hiding this comment.
which are you referring to? perhaps we need to file a jira so we don't forget
sandeep-paliwal
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alternative implementation to #892, here the idea is to hook on the Console config loading and extract the
oauth_server_to_servercredential only. We can add more credential types later on if needed.The proposed change stores the whole credential in an IMS API query-params compliant environment variable, JSON stringified. Here is an example
As this is exposed to the user's
.envthe goal is readability and ease of retrieval. Having a single JSON var is up to debate, we can also unpack into multiple variables.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: